Require azure/core manually #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'azure' moved part of it to a gem called 'azure_core'. They released a version that lists that gem as a dependency. When this version is used with 'fog-azure', we get an error because 'azure/core' isn't loaded (see Azure/azure-sdk-for-ruby#383). We can simply preload it in fog-azure and not let the error in the dependency affect us.
Contributor
|
@dLobatog Could you please re-verify whether we still need this fix as latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'azure' moved part of it to a gem called 'azure_core'. They released a
version that lists that gem as a dependency. When this version is
used with 'fog-azure', we get an error because 'azure/core' isn't loaded
(see Azure/azure-sdk-for-ruby#383).
We can simply preload it in fog-azure and not let the error in the
dependency affect us. We could also force the dependency to be a version before the split into 'azure' and 'azure_core'.
I think we'd need a new release after merging this change, as it stands right now fog-azure is broken (at least until Azure/azure-sdk-for-ruby#383 is merged and a new release comes out)