Fixed incorrect escaping of group name when sending LDAP request in GroupsLoader#11
Open
josefsabl wants to merge 1 commit intofoglcz:masterfrom
Open
Fixed incorrect escaping of group name when sending LDAP request in GroupsLoader#11josefsabl wants to merge 1 commit intofoglcz:masterfrom
josefsabl wants to merge 1 commit intofoglcz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found out that incorrect escaping method was used. Although it looks that we should have used *DN version as we are escaping group dn, *FILTER variant is the correct one to use as we use the DN in the search filter. Groups that contained parentheses produced a search failed error.