Skip to content

Conversation

@aa5sh
Copy link

@aa5sh aa5sh commented Oct 14, 2025

Added completers for US County and Award Summary. This could be extended for other subdivisions if desired.

Added completers for US County and Award Summary.
@foldynl
Copy link
Owner

foldynl commented Oct 14, 2025

Michael, if we did it this way, it would become a very hot topic, and we’d probably have to change it a month after the release. The thing is, right after the release, users outside the US would start bombarding us with questions about why we’re only implementing the US. Unfortunately, your current implementation doesn’t support multiple regions.

Here’s what I would change:

  1. The resource file is fine, but don’t store it in the database. We already have similar lists stored as QHash or QMap. It will need to be done cleverly, because you’ll need mappings from DXCC entities to counties, and you’ll also need it in Awards.

  2. I’d expand the resource file to include the DXCC entity and a field description. I know JSON is quite large, but it’s self-documenting, which is an advantage.

  3. The data source is missing. CNTY is defined in ADIF, including which values it can have. This will need to be updated over time, so it would be good to specify where the source comes from.

@aa5sh
Copy link
Author

aa5sh commented Oct 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants