Skip to content

CIRCSTOR-620: Add hold trigger to notice enum#538

Merged
mhamann-ubl merged 2 commits intomasterfrom
CIRCSTOR-620
Nov 10, 2025
Merged

CIRCSTOR-620: Add hold trigger to notice enum#538
mhamann-ubl merged 2 commits intomasterfrom
CIRCSTOR-620

Conversation

@mhamann-ubl
Copy link
Contributor

This PR adds a new notice type as requested per: https://folio-org.atlassian.net/browse/UICIRC-1245

It is the basis for implementing the UI and Middleware components.

@sonarqubecloud
Copy link

Copy link
Contributor

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mhamann-ubl. I'm not really the right person to review this. I've never worked on this codebase — or, in more than trivial ways, on any Java-based FOLIO module. That said, I'm competent to review the addition of an element to an enumeration in a JSON Schema, so I guess it's OK for me to approve this.

@mhamann-ubl
Copy link
Contributor Author

Hi, @mhamann-ubl. I'm not really the right person to review this. I've never worked on this codebase — or, in more than trivial ways, on any Java-based FOLIO module. That said, I'm competent to review the addition of an element to an enumeration in a JSON Schema, so I guess it's OK for me to approve this.

Thank you @MikeTaylor. Yes, it felt silly to request a review on that change, but I didn't just want to merge it without someone from the team even seeing it. Anyway, I will the merge and close this.

@mhamann-ubl mhamann-ubl merged commit 347f9ae into master Nov 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants