CIRC-2339 Fix borrower preferredFirstName fallback logic#1629
Open
roman-barannyk wants to merge 3 commits intomasterfrom
Open
CIRC-2339 Fix borrower preferredFirstName fallback logic#1629roman-barannyk wants to merge 3 commits intomasterfrom
roman-barannyk wants to merge 3 commits intomasterfrom
Conversation
|
alexanderkurash
approved these changes
Nov 5, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Description
Steps to reproduce:
Set up a Hold slip template with both tokens - borrower.preferredFirstName and requester.preferredFirstName
Check out an item to a patron that only has “First name” and no “Preferred first name”
Place a request from a different patron that only has “First name” and no “Preferred first name”
Check in an item
Print a slip
Expected result:
borrower.preferredFirstName and requester.preferredFirstName behave in the same way - when “Preferred first name” is not available, it falls back to the “First name”
Actual result:
requester.preferredFirstName behaves as expected, but
borrower.preferredFirstName is empty - it doesn’t fall back to the “First name“
Resolves: CIRC-2339