Skip to content

CIRC-2470: Add Hold request for item as trigger for Loan notices #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
slaemmer wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

CIRC-2470: Add Hold request for item as trigger for Loan notices #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
866c399
add new notice event type and logic to trigger notice on hold for item
mhamann-ubl Nov 7, 2025
e2216e5
add count on hold, update tests
mhamann-ubl Nov 7, 2025
a0ab88a
add logic to sendNotice for titleLevel holdRequest
mhamann-ubl Nov 12, 2025
25485a9
CIRC-2470 Extract HoldNotices into separate sender
slaemmer Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/main/java/org/folio/circulation/domain/CreateRequestService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.logging.log4j.Logger;
import org.folio.circulation.domain.representations.logs.LogEventType;
import org.folio.circulation.domain.validation.RequestLoanValidator;
import org.folio.circulation.resources.HoldNoticeSender;
import org.folio.circulation.resources.RequestBlockValidators;
import org.folio.circulation.resources.RequestNoticeSender;
import org.folio.circulation.resources.handlers.error.CirculationErrorHandler;
Expand All @@ -59,19 +60,22 @@ public class CreateRequestService {
private final UpdateUponRequest updateUponRequest;
private final RequestLoanValidator requestLoanValidator;
private final RequestNoticeSender requestNoticeSender;
private final HoldNoticeSender holdNoticeSender;
private final RequestBlockValidators requestBlockValidators;
private final EventPublisher eventPublisher;
private final CirculationErrorHandler errorHandler;

public CreateRequestService(RequestRelatedRepositories repositories,
UpdateUponRequest updateUponRequest, RequestLoanValidator requestLoanValidator,
RequestNoticeSender requestNoticeSender, RequestBlockValidators requestBlockValidators,
EventPublisher eventPublisher, CirculationErrorHandler errorHandler) {
RequestNoticeSender requestNoticeSender, HoldNoticeSender holdNoticeSender,
RequestBlockValidators requestBlockValidators, EventPublisher eventPublisher,
CirculationErrorHandler errorHandler) {

this.repositories = repositories;
this.updateUponRequest = updateUponRequest;
this.requestLoanValidator = requestLoanValidator;
this.requestNoticeSender = requestNoticeSender;
this.holdNoticeSender = holdNoticeSender;
this.requestBlockValidators = requestBlockValidators;
this.eventPublisher = eventPublisher;
this.errorHandler = errorHandler;
Expand Down Expand Up @@ -113,7 +117,9 @@ public CompletableFuture<Result<RequestAndRelatedRecords>> createRequest(
.thenApplyAsync(r -> {
r.after(t -> eventPublisher.publishLogRecord(mapToRequestLogEventJson(t.getRequest()), getLogEventType()));
return r.next(requestNoticeSender::sendNoticeOnRequestCreated);
}).thenApply(r -> logResult(r, "createRequest"));
})
.thenComposeAsync(r -> r.after(this::sendHoldNoticeIfNeeded))
.thenApply(r -> logResult(r, "createRequest"));
}

private Result<RequestAndRelatedRecords> refuseHoldOrRecallTlrWhenPageableItemExists(
Expand Down Expand Up @@ -295,4 +301,7 @@ private LogEventType getLogEventType() {
: REQUEST_CREATED;
}

private CompletableFuture<Result<RequestAndRelatedRecords>> sendHoldNoticeIfNeeded(RequestAndRelatedRecords records) {
return holdNoticeSender.sendHoldNoticeIfNeeded(records.getRequest()).thenApply(v -> Result.succeeded(records));
}
}
1 change: 1 addition & 0 deletions src/main/java/org/folio/circulation/domain/notice/NoticeEventType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public enum NoticeEventType {
DUE_DATE("Due date"),
ITEM_RECALLED("Item recalled"),
AGED_TO_LOST("Aged to lost"),
HOLD_REQUEST_FOR_ITEM("Hold request for item"),

// Request notices,
PAGING_REQUEST("Paging request"),
Expand Down
Loading