MODINVUP-128 follow up #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- also in FileQueue: tweak method names, method visibility -- other minor code clean up
...ava/org/folio/inventoryupdate/importing/service/delivery/fileimport/reporting/Reporting.java
Outdated
Show resolved
Hide resolved
Comment on lines
113
to
+115
| + filesProcessed + " file(s) with " + recordsProcessed.get() | ||
| + " records processed in " + processingTimeAsString(processingTime) + " (" | ||
| + (recordsProcessed.get() * 1000000000L / processingTime) + " recs/s.)") | ||
| + " records processed in " + processingTimeAsString(processingTimeNanos) + " (" | ||
| + (recordsProcessed.get() * NANOS_PER_SECOND / processingTimeNanos) + " recs/s.)") |
Contributor
There was a problem hiding this comment.
The statistics string in line 113-115 can be put into a variable and re-used in line 121 to avoid code duplication.
…very/fileimport/reporting/Reporting.java Co-authored-by: julianladisch <533612+julianladisch@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODINVUP-128, write source files to file queue asynchronously
-- also in FileQueue: tweak method names, method visibility
-- other minor code clean up