Skip to content

feat(icons): add more icons/patterns, cleanup#937

Draft
minusfive wants to merge 2 commits intofolke:mainfrom
minusfive:add-icons
Draft

feat(icons): add more icons/patterns, cleanup#937
minusfive wants to merge 2 commits intofolke:mainfrom
minusfive:add-icons

Conversation

@minusfive
Copy link
Copy Markdown

@minusfive minusfive commented Jan 23, 2025

Note

Depends on #935 to work properly. That change is temporarily included in this PR for testing, but will be rebased on main if/when #935 is merged

Description

This PR:

  • adds a bunch more icons / patterns
  • cleans up the rules table to make it easier to parse / maintain
  • resolves some priority mismatches by re-sorting or adding pattern specificity
  • improves consistency by replacing some icons with their equivalents in the same icon style and/or source as the majority of existing icons

Related Issue(s)

N/A

Screenshots

Screenshot 2025-01-23 at 15 51 15
Screenshot 2025-01-23 at 15 40 52
Screenshot 2025-01-23 at 15 40 58
Screenshot 2025-01-23 at 15 41 20
Screenshot 2025-01-23 at 15 41 32
Screenshot 2025-01-23 at 15 41 40
Screenshot 2025-01-23 at 15 41 49
Screenshot 2025-01-23 at 15 42 08
Screenshot 2025-01-23 at 15 51 59
Screenshot 2025-01-23 at 15 42 35
Screenshot 2025-01-23 at 15 51 29
Screenshot 2025-01-23 at 15 42 45
Screenshot 2025-01-23 at 15 43 01
Screenshot 2025-01-23 at 15 51 22
Screenshot 2025-01-23 at 15 44 02

Otherwise all plugin keymaps are forced to use the same icon, can't be
granularly customized
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Feb 24, 2025
iSplasher added a commit to isplasher-forks/which-key.nvim that referenced this pull request Jun 20, 2025
iSplasher added a commit to isplasher-forks/which-key.nvim that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue or PR has been inactive for a while

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant