Update README.md with detailed step by step local build info#171
Closed
Update README.md with detailed step by step local build info#171
Conversation
| cd fontra-pak ; | ||
| python3 -m venv venv ; | ||
|
|
||
| 3. Install the python package requirements: |
Member
There was a problem hiding this comment.
It's missing the venv activation step.
|
|
||
| 5. Run the application: | ||
|
|
||
| ./dist/Fontra\ Pak ; |
Member
There was a problem hiding this comment.
This would be incorrect for macOS and Windows.
| ## Download | ||
|
|
||
| Nightly builds can be downloaded from the topmost [“Build Application”](https://github.com/googlefonts/fontra-pak/actions) workflow. You need to be signed in to GitHub to be able to download. | ||
| Nightly builds can be downloaded from the topmost [“Build Application”](https://github.com/googlefonts/fontra-pak/actions) workflow. |
Member
There was a problem hiding this comment.
Nightly builds can also be downloaded from fontra.xyz, which doesn't require GH login. We should probably mention that first.
Merged
Member
|
This is superseded by #208. Perhaps there need to be more detailed instructions to run or build from the sources on Linux, but I think these should be added to the docs instead, as these are more targeted towards end users:
I don't think the readme in this repo needs to explain how to clone a repo and how to set up a virtual environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via @graphicore