Never try to test openssl library when it specified over --with-openssl
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssl` Nginx may use system-level OpenSSL library and old code works fine at this case. But when user specified a custom OpenSSL library over `--with-openssl` this module never build because it can't pass test inside. Also it is impossibly to easy test openssl because it isn't build and nginx will build it during building process. So, skip testing phase inside module when user specified openssl version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx may use system-level OpenSSL library and old code works fine at this case.
But when user specified a custom OpenSSL library over
--with-opensslthis module never build because it can't pass test inside.Also it is impossibly to easy test openssl because it isn't build and nginx will build it during building process.
So, skip testing phase inside module when user specified openssl version.