feat: update features/settings automatically W-20268495 #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Nov 25, 2025
| SfProject, | ||
| SfProjectJson, | ||
| isPackagingDirectory, | ||
| isNamedPackagingDirectory, |
Contributor
Author
There was a problem hiding this comment.
cursor agent review caught that docs referenced these 2 type guards but they weren't exported
mshanemc
commented
Nov 25, 2025
| ]) | ||
| ); | ||
|
|
||
| export type Features = z.infer<typeof FeaturesSchema>; |
Contributor
Author
There was a problem hiding this comment.
some unused exports in the previous pr. this pr adds the knip which we've found really useful at reducing ai slop
mshanemc
commented
Nov 25, 2025
| import { simpleFeaturesList } from '../../../src/schema/project-scratch-def/simpleFeaturesList'; | ||
|
|
||
| describe('simpleFeaturesList', () => { | ||
| it('should not contain any features with <value> (those belong in patternFeaturesList)', () => { |
Contributor
Author
There was a problem hiding this comment.
one of the features had extra whitespace, so this makes sure that no new pattern gets introduced that will not be properly classified between simple vs. pattern features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scripts to update features/settings
loosely based on SDR's https://github.com/forcedotcom/source-deploy-retrieve/blob/main/.github/workflows/supportedMetadataUpdate.yml
What issues does this PR fix or reference?
@W-20268495@
fix forcedotcom/schemas#81