Merged
Conversation
Member
houtanb
commented
Feb 13, 2026
houtanb
commented
- support stratified sampling for market questions across market value bins and time horizon (days until market close) bins
- keep category-balanced sampling for data sources
- more helpful logging
- generate visuals using plotly when running locally
- general cleanup
jcanedy
reviewed
Feb 16, 2026
| def print_info_message(num_allocated: int, n: int) -> None: | ||
| if num_allocated != n: | ||
| logger.error(f"*** Problem allocating evenly... Allocated {num_allocated:,}/{n}. ***") | ||
| sys.exit(1) |
Member
There was a problem hiding this comment.
nit: I'd potentially throw an exception in order to handle this.
* support stratified sampling for market questions across market value bins and time horizon (days until market close) bins * keep category-balanced sampling for data sources * more helpful logging * generate visuals using plotly when running locally * general cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.