Fixed Forever.stop() killing parent process on Forever.exit()#812
Open
xeaone wants to merge 3 commits intoforeversd:masterfrom
xeaone:master
Open
Fixed Forever.stop() killing parent process on Forever.exit()#812xeaone wants to merge 3 commits intoforeversd:masterfrom xeaone:master
xeaone wants to merge 3 commits intoforeversd:masterfrom
xeaone:master
Conversation
Member
|
Thank you for your contribution. Unfortunately this breaks almost every single test. Could you look into getting CI/CD passing? |
Contributor
|
Could you please fix tests? |
Author
|
I can take a look at it. I am not familiar with writing tests like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Forever.stop() killing parent process on Forever.exit()
Added exitOnStop option to Forever.config
Changed exitOnStop default false
Fixed exitOnStop always being true