This repository was archived by the owner on Sep 8, 2025. It is now read-only.
fix: set user ID upon DBUser.save() #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
realaravinth
commented
Apr 14, 2022
realaravinth
commented
SUMMARY
DBIssue and DBComment loaded data from database when performing
updates via self.__update() which in some cases where unnecessary as a
fetch would have been performed just before invoking __update().
This patch introduces an optical parameter to provide recently
loaded data from DB
Member
Author
|
CI failure is related to test instability(coverage run has passed, but the build run has failed 🙃) addressed in #98, kindly ignore CI for this PR. |
dat-adi
approved these changes
Apr 16, 2022
Member
dat-adi
left a comment
dat-adi
left a comment
There was a problem hiding this comment.
Changes look good to go for a merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.