Fix nil pointer dereference in hasRated resolver (closes #71) #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a nil pointer dereference that occurs when requesting the hasRated field on the RecipeRevision type without sending an auth token.
The issue was in api/graph/directives.resolvers.go at line 19, where the code was checking session expiry without first verifying that the session exists. When no auth token is provided, session is nil, causing a panic when trying to access the Expiry.Time field.
The fix adds a nil check for the session and simplifies the condition by removing the !required check, allowing the resolver to handle unauthenticated requests gracefully.
Checklist
Related Issues
Closes #71