Skip to content

FIO-9258: separated webform options from angular webform options, fix some eslint errors, fix form options type#1124

Merged
brendanbond merged 2 commits intomasterfrom
FIO-9258-give-formio-component-options-type
Feb 6, 2025
Merged

FIO-9258: separated webform options from angular webform options, fix some eslint errors, fix form options type#1124
brendanbond merged 2 commits intomasterfrom
FIO-9258-give-formio-component-options-type

Conversation

@ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9258

Description

What changed?

Gave the angular formio component options the webform options type along with extending the specific angular webform options as well. Also fixed some eslint errors

Why have you chosen this solution?

Give correct type definitions to formio

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

Manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@ZenMasterJacob20011 ZenMasterJacob20011 force-pushed the FIO-9258-give-formio-component-options-type branch from a13baa4 to 875a2ac Compare February 5, 2025 15:41
@ZenMasterJacob20011 ZenMasterJacob20011 force-pushed the FIO-9258-give-formio-component-options-type branch from 875a2ac to 962f3dd Compare February 5, 2025 16:37
Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@brendanbond brendanbond merged commit f439607 into master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants