feat: get_file_size - gets the size of a file in bytes#1029
Open
wassup05 wants to merge 8 commits intofortran-lang:masterfrom
Open
feat: get_file_size - gets the size of a file in bytes#1029wassup05 wants to merge 8 commits intofortran-lang:masterfrom
get_file_size - gets the size of a file in bytes#1029wassup05 wants to merge 8 commits intofortran-lang:masterfrom
Conversation
perazz
reviewed
Sep 1, 2025
|
|
||
| --- | ||
|
|
||
| ## `get_file_size` - Gets the size (in bytes) of a file. |
Member
There was a problem hiding this comment.
We have not used get_* patterns anywhere else so, this function may perhaps just be file_size? The fact that it is a function already means we're get_ting stuff.
Comment on lines
+1142
to
+1158
| type(state_type) :: err0 | ||
| integer :: code | ||
| integer(c_int64_t) :: c_size | ||
|
|
||
| if (is_directory(path)) then | ||
| err0 = FS_ERROR("Is a directory!") | ||
| call err0%handle(err) | ||
| return | ||
| end if | ||
|
|
||
| code = stdlib_get_file_size(to_c_char(trim(path)), c_size) | ||
|
|
||
| if (code /= 0) then | ||
| err0 = FS_ERROR_CODE(code, c_get_strerror()) | ||
| call err0%handle(err) | ||
| return | ||
| end if |
Member
There was a problem hiding this comment.
This functionality can be achieved by Fortran intrinsics only. Perhaps that would be a good way to avoid cross-platform CI issues and avoid the C backend calls?
Suggested change
| type(state_type) :: err0 | |
| integer :: code | |
| integer(c_int64_t) :: c_size | |
| if (is_directory(path)) then | |
| err0 = FS_ERROR("Is a directory!") | |
| call err0%handle(err) | |
| return | |
| end if | |
| code = stdlib_get_file_size(to_c_char(trim(path)), c_size) | |
| if (code /= 0) then | |
| err0 = FS_ERROR_CODE(code, c_get_strerror()) | |
| call err0%handle(err) | |
| return | |
| end if | |
| type(state_type) :: err0 | |
| integer :: code | |
| character(len=256) :: iomsg | |
| integer(c_int64_t) :: c_size | |
| if (is_directory(path)) then | |
| err0 = FS_ERROR("Is a directory!") | |
| call err0%handle(err) | |
| return | |
| end if | |
| inquire(file=path, size=c_size, iostat=code, iomsg=iomsg) | |
| if (code /= 0) then | |
| err0 = FS_ERROR_CODE(code, iomsg) | |
| call err0%handle(err) | |
| return | |
| end if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing function added is
get_file_size(path [, err])It returns the file size in bytes. It returns an error if the
pathis a directory or a symlink to a directory (because for the size of directories you will need to recurse into the directory and add all its component sizes to get its actual size)It uses
statand_stati64on POSIX and windows respectively. It returns an integer ofkindint64to handle large enough file sizes.