-
Notifications
You must be signed in to change notification settings - Fork 224
feat(linalg): add generalized least squares solver #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aamrindersingh
wants to merge
12
commits into
fortran-lang:master
Choose a base branch
from
aamrindersingh:1047-feat-generalized-lstsq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9e16d37
feat(linalg): add generalized least squares solver
aamrindersingh 82ab371
Update src/linalg/stdlib_linalg_least_squares.fypp
aamrindersingh fbb6c69
docs: clarify SPD (real) / HPD (complex) for GLS, add zero parameter
aamrindersingh 703ae17
test: remove unused tol variable in generalized_lstsq test
aamrindersingh 4764aa9
refactor(generalized_lstsq): use optval, cholesky subroutine, and do …
aamrindersingh 296727a
fix(handle_ggglm_info): expand select case with specific error messages
aamrindersingh 5a70184
Add overwrite_w, SVD-based sqrt test, improve error messages
aamrindersingh 0b5f9ad
Use eye/hermitian in tests, document Cholesky zeroing, fix error prop…
aamrindersingh 07417f8
removed where_at error handling
aamrindersingh 8c82fab
add solve_generalized_lstsq subroutine, fix docs and allocate style
aamrindersingh 34e840d
fix: address review comments for generalized_lstsq
aamrindersingh 3640093
Update src/linalg/stdlib_linalg.fypp
perazz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| ! Generalized least-squares solver with correlated errors | ||
| program example_generalized_lstsq | ||
| use stdlib_linalg_constants, only: dp | ||
| use stdlib_linalg, only: generalized_lstsq, solve_generalized_lstsq | ||
| implicit none | ||
|
|
||
| integer, parameter :: m = 3 | ||
| real(dp) :: A(m,2), b(m), W(m,m), x(2) | ||
| real(dp), allocatable :: x_fun(:) | ||
|
|
||
| ! Design matrix: intercept + slope | ||
| A(:,1) = 1.0_dp | ||
| A(:,2) = [1.0_dp, 2.0_dp, 3.0_dp] | ||
|
|
||
| ! Observations | ||
| b = [1.0_dp, 2.1_dp, 2.9_dp] | ||
|
|
||
| ! Covariance matrix (correlated errors) | ||
| W = reshape([1.0_dp, 0.5_dp, 0.25_dp, & | ||
| 0.5_dp, 1.0_dp, 0.5_dp, & | ||
| 0.25_dp, 0.5_dp, 1.0_dp], [m, m]) | ||
|
|
||
| ! Function interface: allocates solution | ||
| x_fun = generalized_lstsq(W, A, b) | ||
| print '("GLS (function): intercept = ",f8.4,", slope = ",f8.4)', x_fun(1), x_fun(2) | ||
|
|
||
| ! Subroutine interface: user-provided solution vector | ||
| call solve_generalized_lstsq(W, A, b, x) | ||
| print '("GLS (subroutine): intercept = ",f8.4,", slope = ",f8.4)', x(1), x(2) | ||
|
|
||
| end program example_generalized_lstsq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,13 +40,15 @@ module stdlib_linalg | |||||
| public :: lstsq_space | ||||||
| public :: constrained_lstsq | ||||||
| public :: constrained_lstsq_space | ||||||
| public :: generalized_lstsq | ||||||
| public :: norm | ||||||
| public :: mnorm | ||||||
| public :: get_norm | ||||||
| public :: solve | ||||||
| public :: solve_lu | ||||||
| public :: solve_lstsq | ||||||
| public :: solve_constrained_lstsq | ||||||
| public :: solve_generalized_lstsq | ||||||
| public :: trace | ||||||
| public :: svd | ||||||
| public :: svdvals | ||||||
|
|
@@ -679,6 +681,84 @@ module stdlib_linalg | |||||
| #:endfor | ||||||
| end interface | ||||||
|
|
||||||
| interface generalized_lstsq | ||||||
| !! version: experimental | ||||||
| !! | ||||||
| !! Computes the generalized least-squares solution to \( \min_x (Ax-b)^T W^{-1} (Ax-b) \) | ||||||
| !! ([Specification](../page/specs/stdlib_linalg.html#generalized-lstsq)) | ||||||
| !! | ||||||
| !!### Summary | ||||||
| !! Function interface for computing generalized least-squares via GGGLM. | ||||||
| !! | ||||||
| !!### Description | ||||||
| !! | ||||||
| !! This interface provides methods for computing generalized least-squares | ||||||
| !! with a symmetric (real) or Hermitian (complex) positive definite covariance matrix. | ||||||
| !! Supported data types include `real` and `complex`. | ||||||
| !! | ||||||
| !!@note The solution is based on LAPACK's `*GGGLM` routine. | ||||||
| !! | ||||||
| #:for rk,rt,ri in RC_KINDS_TYPES | ||||||
| module function stdlib_linalg_${ri}$_generalized_lstsq(w,a,b,prefactored_w,overwrite_a,overwrite_w,err) result(x) | ||||||
jvdp1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| !> Covariance matrix W(m,m) (symmetric/Hermitian positive definite) or its matrix square root | ||||||
| ${rt}$, intent(inout), target :: w(:,:) | ||||||
| !> Input matrix a(m,n) | ||||||
| ${rt}$, intent(inout), target :: a(:,:) | ||||||
| !> Right hand side vector b(m) | ||||||
| ${rt}$, intent(in) :: b(:) | ||||||
| !> [optional] Is W already a matrix square root (e.g., Cholesky factor)? Default: .false. | ||||||
| logical(lk), optional, intent(in) :: prefactored_w | ||||||
| !> [optional] Can A data be overwritten and destroyed? | ||||||
| logical(lk), optional, intent(in) :: overwrite_a | ||||||
| !> [optional] Can W data be overwritten and destroyed? Default: .false. | ||||||
| logical(lk), optional, intent(in) :: overwrite_w | ||||||
| !> [optional] state return flag. On error if not requested, the code will trigger an error stop | ||||||
| type(linalg_state_type), optional, intent(out) :: err | ||||||
| !> Result array x(n) | ||||||
| ${rt}$, allocatable :: x(:) | ||||||
| end function stdlib_linalg_${ri}$_generalized_lstsq | ||||||
| #:endfor | ||||||
| end interface generalized_lstsq | ||||||
|
|
||||||
| interface solve_generalized_lstsq | ||||||
| !! version: experimental | ||||||
| !! | ||||||
| !! Computes the generalized least-squares solution to \( \min_x (Ax-b)^T W^{-1} (Ax-b) \) | ||||||
| !! ([Specification](../page/specs/stdlib_linalg.html#solve-generalized-lstsq)) | ||||||
| !! | ||||||
| !!### Summary | ||||||
| !! Subroutine interface for computing generalized least-squares via GGGLM. | ||||||
| !! | ||||||
| !!### Description | ||||||
| !! | ||||||
| !! This interface provides methods for computing generalized least-squares | ||||||
| !! with a symmetric (real) or Hermitian (complex) positive definite covariance matrix. | ||||||
| !! Supported data types include `real` and `complex`. | ||||||
| !! | ||||||
| !!@note The solution is based on LAPACK's `*GGGLM` routine. | ||||||
| !! | ||||||
| #:for rk,rt,ri in RC_KINDS_TYPES | ||||||
| module subroutine stdlib_linalg_${ri}$_solve_generalized_lstsq(w,a,b,x,prefactored_w,overwrite_a,overwrite_w,err) | ||||||
| !> Covariance matrix W(m,m) (symmetric/Hermitian positive definite) or its matrix square root | ||||||
| ${rt}$, intent(inout), target :: w(:,:) | ||||||
| !> Input matrix a(m,n) | ||||||
| ${rt}$, intent(inout), target :: a(:,:) | ||||||
| !> Right hand side vector b(m) | ||||||
| ${rt}$, intent(in) :: b(:) | ||||||
| !> Solution vector x(n) | ||||||
| ${rt}$, intent(out) :: x(:) | ||||||
| !> [optional] Is W already a matrix square root (e.g., Cholesky factor)? Default: .false. | ||||||
| logical(lk), optional, intent(in) :: prefactored_w | ||||||
| !> [optional] Can A data be overwritten and destroyed? | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| logical(lk), optional, intent(in) :: overwrite_a | ||||||
| !> [optional] Can W data be overwritten and destroyed? Default: .false. | ||||||
| logical(lk), optional, intent(in) :: overwrite_w | ||||||
| !> [optional] state return flag. On error if not requested, the code will stop | ||||||
| type(linalg_state_type), optional, intent(out) :: err | ||||||
| end subroutine stdlib_linalg_${ri}$_solve_generalized_lstsq | ||||||
| #:endfor | ||||||
| end interface solve_generalized_lstsq | ||||||
|
|
||||||
| ! QR factorization of rank-2 array A | ||||||
| interface qr | ||||||
| !! version: experimental | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could mention here that, if the Cholesky factor is used, user need to have zeroed-out the other triangular part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why asking that to the user, and not to do it internally?
If asked to the user, should there be an internal check to ensure that it is really the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cholesky factors are not the only matrix square-root one can use. If you use
svdand take the square-root of the singular values, it'll be a valid square-root although it won't have the upper or lower triangular structure of the Cholesky factor. In order to check internally whether the upper (lower) triangular part has been zeroed-out by the user, we would need to know for sure that the pre-factoredWmatrix has been obtained with Cholesky. And even there, we would need to know whetherUorLis being used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. thank you for the explanation. Could we then add something like that to warn the user that is up to its responsability:
"It is the user's responsibility to ensure that the prefactored matrix B is valid."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure enough !