Skip to content

Fix(system_subprocess): save_completed_state passing stderr instead of stdin to callback #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahmood-Sinan wants to merge 3 commits into
base: master
Choose a base branch
from
+59 −3
Open

Fix(system_subprocess): save_completed_state passing stderr instead of stdin to callback #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23ad95b
fix: pass stdin to callback instead or duplicated stderr
Mahmood-Sinan Mar 26, 2026
83f3352
add test for callback
Mahmood-Sinan Mar 26, 2026
91be530
minor changes
Mahmood-Sinan Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/system/stdlib_system_subprocess.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ subroutine save_completed_state(process,delete_files)
if (associated(process%oncomplete)) &
call process%oncomplete(process%id, &
process%exit_code, &
process%stderr, &
process%stdin, &
process%stdout, &
process%stderr, &
process%payload)
Expand Down
60 changes: 58 additions & 2 deletions test/system/test_subprocess.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
module test_subprocess
use testdrive, only : new_unittest, unittest_type, error_type, check, skip_test
use stdlib_system, only: process_type, run, runasync, is_running, wait, update, elapsed, is_windows, kill
use stdlib_system, only: process_type, run, runasync, is_running, wait, update, elapsed, is_windows, kill, process_id

implicit none

type :: payload_wrapper
Copy link
Copy Markdown
Member

@jvdp1 jvdp1 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be the DT string_type of stdlib used?

Copy link
Copy Markdown
Contributor Author

@Mahmood-Sinan Mahmood-Sinan Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried, the compiler gave me an error saying that

  193 |             type is (string_type)
      |                                 1
Error: The type-spec shall not specify a sequence derived type or a type with the BIND attribute in SELECT TYPE at (1) [F2003:C815]

I supposed we cannot do so, since string_type has sequence attribute.

character(len=20) :: payload(3) ! wrapper type for preserving type info
end type

contains

!> Collect all exported unit tests
Expand All @@ -16,7 +20,8 @@ subroutine collect_suite(testsuite)
new_unittest('test_run_asynchronous', test_run_asynchronous), &
new_unittest('test_process_kill', test_process_kill), &
new_unittest('test_process_state', test_process_state), &
new_unittest('test_input_redirection', test_input_redirection) &
new_unittest('test_input_redirection', test_input_redirection), &
new_unittest('test_callback', test_callback) &
]
end subroutine collect_suite

Expand Down Expand Up @@ -145,6 +150,57 @@ subroutine test_input_redirection(error)

end subroutine test_input_redirection

subroutine test_callback(error)
type(error_type), allocatable, intent(out) :: error
type(process_type) :: process
character(len=:), allocatable :: command
type(payload_wrapper) :: payload_wrapper_
character(len=*), parameter :: input_string = "test input"

if (is_windows()) then
command = "sort"
else
command = "cat"
endif

payload_wrapper_%payload = ""

process = run(command, stdin=input_string, want_stdout=.true., want_stderr=.true.,&
callback=callback_function, payload=payload_wrapper_)

call check(error, process%completed, "Process did not complete")
if (allocated(error)) return
call check(error, process%exit_code == 0, "Process exited with non-zero exit code")
if (allocated(error)) return
call check(error, process%stdout == input_string, "Process stdout does not match expected input")
if (allocated(error)) return
call check(error, len_trim(process%stderr) == 0, "Process stderr is not empty")
if (allocated(error)) return
call check(error, trim(payload_wrapper_%payload(1)) == input_string, "Callback stdin mismatch")
if (allocated(error)) return
call check(error, trim(payload_wrapper_%payload(2)) == input_string, "Callback stdout mismatch")
if (allocated(error)) return
call check(error, len_trim(payload_wrapper_%payload(3)) == 0, "Callback stderr is not empty")
if (allocated(error)) return

end subroutine test_callback

subroutine callback_function(pid, exitcode, stdin, stdout, stderr, payload)
integer(process_id), intent(in) :: pid
integer, intent(in) :: exitcode
character(len=*), optional, intent(in) :: stdin, stdout, stderr
class(*), optional, intent(inout) :: payload

if(present(payload)) then
select type(p=>payload)
type is (payload_wrapper)
if (present(stdin)) p%payload(1) = stdin
if (present(stdout)) p%payload(2) = stdout
if (present(stderr)) p%payload(3) = stderr
end select
end if

end subroutine callback_function
end module test_subprocess

program tester
Expand Down
Loading