-
Notifications
You must be signed in to change notification settings - Fork 40
Feat/476/portal barrier mode #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GiordanoSL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
DeguShi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic seems to be working fine. I'd just suggest adjusting the snake movement/orientation for this specific game mode, as the current implementation makes the sprites' movement look awkward after crossing the barrier. That can be done in a new issue if preferred.
This Pull Request fully implements Portal Barrier Mode (#476) and consolidates the three related subissues required to deliver the new feature:
#478 - Define Components and Entities for Portal Barrier
Added the data structures and ECS entities needed to represent Portals.
#479 - Implement Portal Spawning and Rendering Systems
Implemented the systems responsible for spawning Portals in the game world and rendering them on screen.
#480 - Implement Portal Collision and Teleport Logic
Updated the collision system to correctly detect Snake–Portal interactions. When the snake enters the portal’s entry block, it now performs a safe teleport to the exit block as described in the parent issue.