Skip to content

Conversation

@gusvidigal
Copy link
Collaborator

This fixes a bug that happened with #505, because some values on other files were not changed. Furthermore, it increases the maximum board size from 60 to 90, related to #504, which increased the default board size by 50%.

Copy link
Collaborator

@gustavorspires gustavorspires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the changes are reasonable and work

Copy link
Collaborator

@agathaicmc agathaicmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!

Copy link
Collaborator

@JeanJPNM JeanJPNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this opportunity to define a constant that can be updated easily in the future

@gusvidigal
Copy link
Collaborator Author

Nice catch, I will work on this

@gusvidigal
Copy link
Collaborator Author

I don't know the need for checking manually the minimum board size everywhere, as it is ensured on the settings that it cannot be less than the min stablished.

Copy link
Collaborator

@JeanJPNM JeanJPNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gusvidigal gusvidigal merged commit 628e008 into dev Dec 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants