-
Notifications
You must be signed in to change notification settings - Fork 40
[MINOR] Fixed min size and increased max size #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gustavorspires
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the changes are reasonable and work
agathaicmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this opportunity to define a constant that can be updated easily in the future
|
Nice catch, I will work on this |
|
I don't know the need for checking manually the minimum board size everywhere, as it is ensured on the settings that it cannot be less than the min stablished. |
JeanJPNM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This fixes a bug that happened with #505, because some values on other files were not changed. Furthermore, it increases the maximum board size from 60 to 90, related to #504, which increased the default board size by 50%.