feat: parse window and grid size from CLI #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 16, 2023 18:45
this commit is intended so the game won't render if help is passed as argument
Mandangus
reviewed
Oct 17, 2023
Mandangus
left a comment
Mandangus
left a comment
There was a problem hiding this comment.
Nice changes, gave some feedback regarding possible issues with formatting and maybe adding a 'speed' argument to CLI
| clock = pygame.time.Clock() | ||
|
|
||
| arena = pygame.display.set_mode((WIDTH, HEIGHT)) | ||
|
|
There was a problem hiding this comment.
Maybe it's a good idea to standardize formatting with a linter so we can get consistent whitespaces
|
|
||
| # Update display and move clock. | ||
| pygame.display.update() | ||
| clock.tick(CLOCK_TICKS) |
There was a problem hiding this comment.
can we add a clock_tick scaling factor to the cli arguments? that would resolve the difficulty setting issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.