-
Notifications
You must be signed in to change notification settings - Fork 6
Introduce an external facing Fioconfig API #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
This allows a caller of the API to understand what config paths are being used. Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
Member
Author
|
I was able to get something going pretty quick in fioup with: |
vkhoroz
reviewed
Oct 20, 2025
detsch
approved these changes
Oct 20, 2025
Member
detsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This exposes the minimum surface area of Fioconfig while avoiding some of the more complex things like certificate rotation which aren't supported in Fioup or the community edition of FoundriesFactory. Signed-off-by: Andy Doan <andy@foundries.io>
mike-sul
approved these changes
Oct 21, 2025
Contributor
mike-sul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes does some minor cleanups and then exposes the bare minimum of an API for other Golang modules to use.
The current
internalmodule is quite large, so I did something similar to how we gradually cleaned up the Fioup API and am just wrapping what we need. We can eventually clean this up more if we ever choose to.