Logging changes #72
Logging changes #72
Conversation
This message is debug only and is making output noisy Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
logging-changes
branch
from
fd45cac to
465ab34
Compare
internal/app.go
Outdated
| all_fname := make(map[string]bool) | ||
| for fname, cfgFile := range config.next { | ||
| slog.Info("Extracting file", "file", fname) | ||
| a.InfoLogger("Extracting file", "name", fname) |
There was a problem hiding this comment.
I wonder if we could configure slog in such the way that it modifies output format at the command initialization and does not require any changes in code that uses slog, so each slog.Info/Debug occurrences remain intact.
I believe @detsch investigated such possibility for zerolog, and answer was positive. Specifically, zerolog.Info would produce normal log like message in case of the daemon operation and terminal like output in case of the CLI commands. Now, we need to check it out for slog.
There was a problem hiding this comment.
Setting a custom slog logger when running in CLI mode seems more appropriate. It would allow the output changes we want without needing to replace slog.Info calls.
There was a problem hiding this comment.
I've force-pushed a new variation that is looking better to me.
There was a problem hiding this comment.
now - should I expose this log handler for Fioup to use, or should we just do the same/similar thing in that code base?
There was a problem hiding this comment.
now - should I expose this log handler for Fioup to use, or should we just do the same/similar thing in that code base?
Exposing the handler would be nice, so that we can easily keep the logic consistent among the tools.
The trailing period doesn't match our other logging logic and messes up with the format I'm trying to achieve in the next change Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
logging-changes
branch
2 times, most recently
from
b39d9af to
b92c4f9
Compare
doanac
force-pushed
the
logging-changes
branch
2 times, most recently
from
28a737d to
38274d5
Compare
Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
logging-changes
branch
from
38274d5 to
02aa690
Compare
4 participants
No description provided.