api: Change Extract and CheckIn to include config-changed
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
approved these changes
Oct 24, 2025
detsch
reviewed
Oct 24, 2025
internal/app.go
Outdated
|
|
||
| modtime, err := time.Parse(time.RFC1123, res.Header.Get("Date")) | ||
| modtime, err2 := time.Parse(time.RFC1123, res.Header.Get("Date")) | ||
| if err != nil { |
Member
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if err2 != nil { |
Member
Author
There was a problem hiding this comment.
nice catch. fixed in force push
Callers of `Extract` and `CheckIn` can benefit from knowing if a config file actually changed. Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
config-changed-return
branch
from
77ed74a to
65c039a
Compare
detsch
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers of
ExtractandCheckIncan benefit from knowing if a config file actually changed.