transport: Avoid exception when printing warning after http error #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpDoOnce may return nil for the response in case of errors. This was leading to a nil pointer dereference when trying to log the response. This patch adds a check to avoid accessing the response status code in that case. A second check is also added on the break condition, when err != nil. This should not be needed with the current httpDoOnce implementation, but is added for safety in case of future changes. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
doanac
approved these changes
Nov 1, 2025
Member
doanac
left a comment
doanac
left a comment
There was a problem hiding this comment.
I hit this same bug on Friday and was queuing up something similar. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpDoOnce may return nil for the response in case of errors. This was leading to a nil pointer dereference when trying to log the response. This patch adds a check to avoid accessing the response status code in that case.
A second check is also added on the break condition, when err != nil. This should not be needed with the current httpDoOnce implementation, but is added for safety in case of future changes.