Add support for remote actions #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkhoroz
reviewed
Dec 10, 2025
doanac
force-pushed
the
remote-actions
branch
from
ac8e0a7 to
073c2e5
Compare
vkhoroz
reviewed
Dec 10, 2025
doanac
force-pushed
the
remote-actions
branch
2 times, most recently
from
e8e364a to
e39bcb1
Compare
vkhoroz
approved these changes
Dec 12, 2025
Member
vkhoroz
left a comment
vkhoroz
left a comment
There was a problem hiding this comment.
My only leftover comment goes to the place where we store that cached list of actions.
I'm not sure how the "feature" to allow user modifying the action file is intended to work; as that file will get overwritten on every update which changes remote actions file list.
But, I guess almost nobody would use this; so nobody would complain.
Otherwise, LGTM.
So take my approval.
doanac
force-pushed
the
remote-actions
branch
from
e39bcb1 to
5c4674f
Compare
This provides a mechanism by which we can trigger remote actions using fioconfig and the new `run-and-report` command. In order to prevent the execution of random commands, we include a "actions" directory where a user can be explicit about which remote actions they want to allow for their product. This commit includes a "reboot" command that's been requested in the past. Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
This change helps the user facing UX part of this feature. By sharing what actions are availble to the device, fioctl and webui can know what options to present to the user for triggering a remote action. It can also *reject* an invalid trigger rather than waiting for it to fail.
Signed-off-by: Andy Doan <andy@foundries.io>
doanac
force-pushed
the
remote-actions
branch
from
5c4674f to
05418c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the
run-and-reportchanges we've previously merged into fioconfig to create a mechanism for running remote actions.