Skip to content

Conversation

@ddoktorski
Copy link
Contributor

Towards #3660

@ddoktorski ddoktorski requested a review from a team as a code owner October 21, 2025 11:52
@ddoktorski ddoktorski requested review from MKowalski8 and franciszekjob and removed request for a team October 21, 2025 11:52
@ddoktorski ddoktorski marked this pull request as draft October 21, 2025 11:52
@ddoktorski ddoktorski force-pushed the add-gas-report-logic branch 2 times, most recently from 8a9f925 to 8f3b1f6 Compare October 22, 2025 18:37
@ddoktorski ddoktorski changed the base branch from add-gas-report-logic to share-contracts-data-store October 22, 2025 18:58
@ddoktorski ddoktorski force-pushed the 3660-gas-report branch 2 times, most recently from 8517806 to 73d507a Compare October 23, 2025 12:32
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case when no functions are invoked, we don't display the table. Maybe we should inform a user by displaying info/warning message?

@ddoktorski ddoktorski force-pushed the share-contracts-data-store branch from 1c1e984 to b5ef498 Compare October 24, 2025 12:01
@ddoktorski ddoktorski force-pushed the share-contracts-data-store branch from b5ef498 to 6bd6031 Compare October 28, 2025 09:58
@ddoktorski ddoktorski marked this pull request as ready for review October 28, 2025 10:30
@ddoktorski
Copy link
Contributor Author

In case when no functions are invoked, we don't display the table. Maybe we should inform a user by displaying info/warning message?

We could add a note stating that a gas report hasn't been produced because there were no contract calls, but I'm not sure if that's necessary. Any thoughts @cptartur?

@ddoktorski ddoktorski mentioned this pull request Oct 28, 2025
@cptartur
Copy link
Member

In case when no functions are invoked, we don't display the table. Maybe we should inform a user by displaying info/warning message?

We could add a note stating that a gas report hasn't been produced because there were no contract calls, but I'm not sure if that's necessary. Any thoughts @cptartur?

@ddoktorski a note like that wouldn't hurt IMO, it makes for a "more obvious" user experience.

Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's add a note about no tables produced from my comment above

@ddoktorski ddoktorski force-pushed the share-contracts-data-store branch from 6bd6031 to 764bde2 Compare October 31, 2025 16:36
@ddoktorski ddoktorski force-pushed the share-contracts-data-store branch from 8948cf7 to 1ccfab5 Compare November 6, 2025 12:01
@ddoktorski ddoktorski force-pushed the share-contracts-data-store branch from 1ccfab5 to d6c0fe3 Compare November 6, 2025 13:46
Base automatically changed from share-contracts-data-store to master November 6, 2025 14:12
@ddoktorski ddoktorski enabled auto-merge November 6, 2025 15:37
@ddoktorski ddoktorski added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit c76eb53 Nov 6, 2025
31 of 54 checks passed
@ddoktorski ddoktorski deleted the 3660-gas-report branch November 6, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants