-
Notifications
You must be signed in to change notification settings - Fork 244
Display gas report table #3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display gas report table #3842
Conversation
|
This change is part of the following stack:
Change managed by git-spice. |
8a9f925 to
8f3b1f6
Compare
8517806 to
73d507a
Compare
franciszekjob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case when no functions are invoked, we don't display the table. Maybe we should inform a user by displaying info/warning message?
1c1e984 to
b5ef498
Compare
73d507a to
7c7f179
Compare
b5ef498 to
6bd6031
Compare
7c7f179 to
7aef68f
Compare
We could add a note stating that a gas report hasn't been produced because there were no contract calls, but I'm not sure if that's necessary. Any thoughts @cptartur? |
@ddoktorski a note like that wouldn't hurt IMO, it makes for a "more obvious" user experience. |
cptartur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but let's add a note about no tables produced from my comment above
6bd6031 to
764bde2
Compare
7aef68f to
3c1cce3
Compare
764bde2 to
8948cf7
Compare
3c1cce3 to
709eda4
Compare
8948cf7 to
1ccfab5
Compare
709eda4 to
a38d071
Compare
1ccfab5 to
d6c0fe3
Compare
a38d071 to
5d1dbb5
Compare
Towards #3660