Unify webserver log path retrieval#1287
Conversation
Schamper
left a comment
There was a problem hiding this comment.
Can you use _get_paths instead? That's the currently defined standardized API for this:
dissect.target/dissect/target/plugin.py
Line 504 in 06990b8
See #1082 for more details.
Fixed! |
8f2b207 to
f9137a9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 81.02% 80.99% -0.04%
==========================================
Files 376 376
Lines 33594 33627 +33
==========================================
+ Hits 27221 27237 +16
- Misses 6373 6390 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1287 will not alter performanceComparing Summary
|
|
Fixed the linter, checks should be good now @twiggler |
5afd360 to
99608e4
Compare
Related to #264.
The idea here is to use the
_log_paths()_get_paths()function to retrieve the resolved log paths for the various webservers that we support. Future webservers should implement this function to automatically collect the resolved log files with Acquire. They also need to be added in the Acquire collection module.