Skip to content

Unify webserver log path retrieval#1287

Merged
twiggler merged 13 commits intofox-it:mainfrom
qmadev:fix/webserver_collection
Dec 1, 2025
Merged

Unify webserver log path retrieval#1287
twiggler merged 13 commits intofox-it:mainfrom
qmadev:fix/webserver_collection

Conversation

@qmadev
Copy link
Contributor

@qmadev qmadev commented Aug 16, 2025

Related to #264.

The idea here is to use the _log_paths() _get_paths() function to retrieve the resolved log paths for the various webservers that we support. Future webservers should implement this function to automatically collect the resolved log files with Acquire. They also need to be added in the Acquire collection module.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use _get_paths instead? That's the currently defined standardized API for this:

def _get_paths(self) -> Iterator[Path]:

See #1082 for more details.

@qmadev
Copy link
Contributor Author

qmadev commented Aug 18, 2025

Can you use _get_paths instead? That's the currently defined standardized API for this:

def _get_paths(self) -> Iterator[Path]:

See #1082 for more details.

Fixed!

@qmadev qmadev requested a review from Schamper August 18, 2025 11:41
@qmadev qmadev force-pushed the fix/webserver_collection branch from 8f2b207 to f9137a9 Compare October 24, 2025 14:16
@twiggler twiggler self-requested a review November 19, 2025 11:54
@twiggler twiggler self-requested a review November 20, 2025 16:47
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.99%. Comparing base (3c8e8f6) to head (99608e4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/webserver/apache.py 40.00% 6 Missing ⚠️
dissect/target/plugin.py 40.00% 3 Missing ⚠️
dissect/target/plugins/apps/webserver/iis.py 40.00% 3 Missing ⚠️
dissect/target/plugins/apps/webserver/nginx.py 57.14% 3 Missing ⚠️
dissect/target/plugins/apps/webserver/caddy.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   81.02%   80.99%   -0.04%     
==========================================
  Files         376      376              
  Lines       33594    33627      +33     
==========================================
+ Hits        27221    27237      +16     
- Misses       6373     6390      +17     
Flag Coverage Δ
unittests 80.99% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #1287 will not alter performance

Comparing qmadev:fix/webserver_collection (99608e4) with main (3c8e8f6)

Summary

✅ 9 untouched

@qmadev
Copy link
Contributor Author

qmadev commented Nov 23, 2025

Fixed the linter, checks should be good now @twiggler

@twiggler twiggler force-pushed the fix/webserver_collection branch from 5afd360 to 99608e4 Compare November 27, 2025 16:09
@Schamper Schamper removed their request for review November 27, 2025 16:42
@Schamper Schamper dismissed their stale review November 27, 2025 16:42

Dismissed.

@twiggler twiggler merged commit ad5ef19 into fox-it:main Dec 1, 2025
63 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants