Skip to content

Conversation

@joost-j
Copy link
Contributor

@joost-j joost-j commented Dec 10, 2025

Add the write_sid function, basically the inverse of read_sid. Used in the NTDS parser, and may be of use in the future for other projects.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (94da877) to head (a7a4732).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/util/sid.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #111   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         27      27           
  Lines       1898    1914   +16     
=====================================
- Misses      1898    1914   +16     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #111 will not alter performance

Comparing feature/add_write_sid (a7a4732) with main (94da877)

Summary

✅ 26 untouched
🆕 2 new

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_write_sid_benchmark[S-1-5-21-123456789-268435456-500-False] N/A 52.2 µs N/A
🆕 test_write_sid_benchmark[S-1-5-21-123456789-268435456-500-True] N/A 49.8 µs N/A

@joost-j joost-j requested a review from Schamper December 10, 2025 15:14
@Schamper Schamper merged commit ab5e6d1 into main Dec 10, 2025
30 of 31 checks passed
@Schamper Schamper deleted the feature/add_write_sid branch December 10, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants