Open
Conversation
Noticed from #220 that the docstring of the command type didn't represent the correct output anymore since we now also split the windows arguments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 84.24% 84.24%
=======================================
Files 35 35
Lines 3746 3746
=======================================
Hits 3156 3156
Misses 590 590
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yunzheng
reviewed
Apr 3, 2026
Member
yunzheng
left a comment
There was a problem hiding this comment.
Actually the code block doesn't really make sense to me. The old one didn't really either now that I look back at it.
'c:\\windows\\malware.exe /info' -> windows_path('c:\\windows\\malware.exe) ('/info',)
'/usr/bin/env bash' -> posix_path('/usr/bin/env') ('bash',)
# In this situation, the executable path needs to be quoted.
'c:\\user\\John Doe\\malware.exe /all /the /things' -> windows_path('c:\\user\\John') ('Doe\\malware.exe, '/all', '/the', /things')
wouldn't it be better to show how it works with a inline doctest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed from #220 that the docstring of the command type didn't
represent the correct output anymore since we now also split the windows
arguments.