Skip to content

Conversation

@yutotnh
Copy link

@yutotnh yutotnh commented Jul 20, 2023

Summary

The "editor.formatOnSave": false setting is now respected.

"editor.formatOnSave" is now immediately toggled with or without formatting when changed from True to False or False to True.

resolve #303

Problems that were occurring

When VSCode was started with editor.formatOnSave":true and changed to editor.formatOnSave":false, the formatting continued on saving after the change.

When VSCode was restarted, formatting on save was no longer performed.

Ohter

Warning
The following problem was solved by 8bbc296.

I tried to debug with the latest commit(5ad70a9), but I got the following error and could not check the operation.
The same error occurs without this change.

Activating extension 'foxundermoon.shell-format' failed: ENOENT: no such file or directory, open '/home/yuto/project/vs-shell-format/dist/one_ini_bg.wasm'.

I made this change to tag 7.2.5 (557f0ac) and it worked.

@yutotnh
Copy link
Author

yutotnh commented Jul 21, 2023

In my environment, since commit 2885fbc and its merge commit (f0b43e0) , shell-format has stopped working.

I get the following error message.

image

I made the following changes to 32e6f3c and did yarn install and now shell-format works.

diff --git a/package.json b/package.json
index 9ebc66c..7f70f38 100644
--- a/package.json
+++ b/package.json
@@ -209,7 +209,7 @@
   },
   "dependencies": {
     "diff": "~5.1.0",
-    "editorconfig": "^2.0.0"
+    "editorconfig": "^0.15.3"
   },
   "licenses": [
     {

Sorry if this is a problem specific to my environment.

@yutotnh
Copy link
Author

yutotnh commented Jun 23, 2024

In my environment, since commit 2885fbc and its merge commit (f0b43e0) , shell-format has stopped working.

I get the following error message.

The above problem has been resolved by 8bbc296.
Therefore, it works fine.

@yutotnh yutotnh force-pushed the 303-fix-format-on-save branch from 8bbc296 to 1ed6582 Compare September 2, 2025 13:56
@yutotnh
Copy link
Author

yutotnh commented Sep 2, 2025

@foxundermoon
I have resolved the conflict in yarn.lock that had occurred.
I have also confirmed that works correctly with the latest changes.
I would appreciate it if you could proceed with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"editor.formatOnSave": false doesn't appear to be respected

2 participants