Do not validate or parse url #36
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull this only after pulling
regex_servicebranch.a) After we allow regex matching in "service =" options this is no
longer required to make usage of this option feasible
b) It was the wrong thing to do. Github and other services
authenticate via ssh. And ~/.ssh/config allows to specify arbitrary
names as "Host"s. So users can attach a certain ssh identity to a
certain repo on gitlab. remote.origin.url then usually does not
look like an url anymore and is meaningless tu urllib.parse.
Now, to passport for e.g. github, use:
This is a separate pull request to distinguish between adding the feature on the
regex_servicebranch (which is somewhat backwards compatible) from this change. Not usingurllib.parsemay require users to change their configs. Sincedomain.comeven as a regex still matched the origindomain.comin most cases this should behave fine. Anyway, explicit is better than implicit ;-)