Skip to content

Conversation

@cfi
Copy link

@cfi cfi commented Oct 27, 2015

Pull this only after pulling regex_service branch.

a) After we allow regex matching in "service =" options this is no
longer required to make usage of this option feasible
b) It was the wrong thing to do. Github and other services
authenticate via ssh. And ~/.ssh/config allows to specify arbitrary
names as "Host"s. So users can attach a certain ssh identity to a
certain repo on gitlab. remote.origin.url then usually does not
look like an url anymore and is meaningless tu urllib.parse.

Now, to passport for e.g. github, use:

  service = github(.com)?(:.*)?

This is a separate pull request to distinguish between adding the feature on the regex_service branch (which is somewhat backwards compatible) from this change. Not using urllib.parse may require users to change their configs. Since domain.com even as a regex still matched the origin domain.com in most cases this should behave fine. Anyway, explicit is better than implicit ;-)

a) After we allow regex matching in "service =" options this is no
   longer required to make usage of this option feasible
b) It was the wrong thing to do. Github and other services
   authenticate via ssh. And ~/.ssh/config allows to specify arbitrary
   names as "Host"s. So users can attach a certain ssh identity to a
   certain repo on gitlab. remote.origin.url then usually does not
   look like an url anymore and is meaningless tu urllib.parse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant