Handle SSH urls better and avoid race conditions when setting git local configs #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicit in the URL
…the next to avoid race conditions on the locked .git/config file
Author
|
This should address at least some of issue #31 |
Author
|
And issue #37 |
|
This worked perfect for me. Would be nice to have it merged (or forked by someone with more time for PRs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a simple pull request fixing a couple issues I had locally when using this tool.
The SSH urls from github and elsewhere (ie. git@github.com:project/path/thing.git) weren't handled well by urllib without an explicit ssh:// scheme on the front, so to handle this I simply check if the parse failed, tack on a ssh:// and try again.
I got race conditions trying to set username and email without adding the git_process.wait() to the get_config method.