feat: handle transactions from composer actions in debugger #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stephancill
force-pushed
the
feat/miniapp-txs
branch
from
fc10b9b to
58369ce
Compare
| export type SignFrameActionFunc< | ||
| TSignerStorageType = Record<string, unknown>, | ||
| TFrameActionBodyType extends FrameActionBodyPayload = FrameActionBodyPayload, | ||
| TFrameContextType extends FrameContext = FarcasterFrameContext, |
Collaborator
There was a problem hiding this comment.
We should probably create a prettier config that doesn't remove those commas. Introduces unnecessary changes in diff.
michalkvasnicak
approved these changes
Oct 24, 2024
Collaborator
michalkvasnicak
left a comment
michalkvasnicak
left a comment
There was a problem hiding this comment.
Approved, great work! I would just introduce prettier config and keep the trailingComma: all so it doesn't change the types.
stephancill
force-pushed
the
feat/miniapp-txs
branch
from
6ee4716 to
a076c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Merge Checklist