Skip to content

Parent initializes by existing iframe#12

Open
aiji42 wants to merge 1 commit intofranleplant:masterfrom
aiji42:feature/parent-by-existing-iframe
Open

Parent initializes by existing iframe#12
aiji42 wants to merge 1 commit intofranleplant:masterfrom
aiji42:feature/parent-by-existing-iframe

Conversation

@aiji42
Copy link

@aiji42 aiji42 commented Dec 28, 2020

Issue

#4

What I did.

  • updated src/Parent.ts
    • Changed the argument type to Union.
      • type IConstructorArgs = IConstructorByUrlArgs | IConstructorByElementArgs;
    • Changed to initialize by conditional branching from argument types.
      • This is verbose, so it may be better to split it into several functions.
  • created examples/parentExistingIframe.html

What I didn't do.

  • No change src/index.test.ts / src/integration.test.ts.
  • The README has not been changed.
    • I will respond if changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant