fix: use frappe.db.count instead of get_list for counting records#1482
Open
badal8381 wants to merge 1 commit intofrappe:developfrom
Open
fix: use frappe.db.count instead of get_list for counting records#1482badal8381 wants to merge 1 commit intofrappe:developfrom
badal8381 wants to merge 1 commit intofrappe:developfrom
Conversation
Replaced frappe.get_list with count(*) field approach with frappe.db.count() which is more reliable for counting records and fixes lead loading issues in the CRM portal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The CRM portal was failing to load leads due to the way record counts were being fetched. The previous implementation used:
frappe.get_list(doctype, filters=filters, fields="count(*) as total_count")[0].total_count
This approach can be unreliable and may fail in certain edge cases.
Solution
Replaced with the more robust and recommended Frappe API method:
frappe.db.count(doctype, filters=filters)
This change was applied in two locations within crm/api/doc.py:
Test Plan