feat: add AAX support #366
Conversation
|
This is a WIP but I put it up as I could use some help working through it. Also, before I go any further is there interest in AAX support? |
| if((NOT CLAP_WRAPPER_OUTPUT_NAME ) OR (CLAP_WRAPPER_OUTPUT_NAME STREQUAL "")) | ||
| set(CLAP_WRAPPER_OUTPUT_NAME "clapasvst3") | ||
| message(WARNING "clap-wrapper: CLAP_WRAPPER_OUTPUT_NAME not set - continuing with a default name `clapasvst3`") | ||
| set(CLAP_WRAPPER_OUTPUT_NAME "clap") |
| endif() | ||
|
|
||
| if (NOT ${CMAKE_GENERATOR} STREQUAL "Xcode") | ||
| message(STATUS "clap-wrapper: will copy ${MBF_TARGET} bundle flag after build") |
There was a problem hiding this comment.
AAX docs:
This file must include the concatenation of the plug-in's CFBundlePackageType (TDMw or BNDL) and CFBundleSignature (PTul)
There was a problem hiding this comment.
Got it. Well probably the right approach is to add an argument for "PKGINFO_FILE" to the oneargs above, default it to macBundlePkgInfo, and then have the wrap_as_aax set it when it calls this function rather than putting AAX logic all the way down here.
For instance, if you are building an AAX and a CLAP this will use the AAX for both. So I think this logic needs to be moved to above this.
|
Ahhh! @defiantnerd has AAX working on a branch also. there is definitely interest. @defiantnerd how does this compare with your effort? |
|
Also @andrewrynhard do you use discord? We should invite you to clap dev discord if so (if you aren't there) |
|
Thanks Andrew. I am already on implementing AAX, but maybe we can share efforts. I can put my work on github, too. |
|
Definitely interest in AAX, thank you! |
|
I will incorporate Andrews changes into my branch and update the branch then. I'll try to get some time for it on the weekend. |
|
Great. And @defiantnerd maybe lets just merge it into next with a cmake thing that errors out if you use it unless you set |
4 participants
No description provided.