Skip to content

Conversation

@SamWindell
Copy link
Contributor

We were not considering inDesiredNameLength, which I think is a problem if you have long module names in your CLAP.

Does this change look reasonable?

I will say that 2 months ago I got a report that I user had a crash in this function. I implemented this change and I have seen no further reports of this issue.

   ausdk::AUMethodGetProperty (/Users/runner/.cache/zig/p/N-V-__8AABXaAwCPe89grjjAXjcvmKwtSHo-0bx570E4IGYf/src/AudioUnitSDK/AUPlugInDispatch.cpp:157)
   ausdk::AUBase::DispatchGetProperty (/Users/runner/.cache/zig/p/N-V-__8AABXaAwCPe89grjjAXjcvmKwtSHo-0bx570E4IGYf/src/AudioUnitSDK/AUBase.cpp:627)
   free_audio::auv2_wrapper::WrapAsAUV2::CopyClumpName (/Users/runner/.cache/zig/p/N-V-__8AAI0aEAAgIOKJQmqSWnD9V2gBob6pqElBItNJFfsE/src/wrapasauv2.cpp:534)
   free_audio::auv2_wrapper::Clumps::getClump (/Users/runner/.cache/zig/p/N-V-__8AAI0aEAAgIOKJQmqSWnD9V2gBob6pqElBItNJFfsE/src/detail/auv2/auv2_base_classes.h:109)
   null (external-file)
   null (external-file)
   null (external-file)
   null (external-file)
   __ubsan_handle_type_mismatch_v1 (src/utils/debug/debug.cpp:235)
   HandleUbsanError (src/utils/debug/debug.cpp:81)

@defiantnerd defiantnerd added bug Something isn't working duplicate This issue or pull request already exists auv2 Everything related to AudioUnit V2 and removed duplicate This issue or pull request already exists labels Jul 18, 2025
@defiantnerd defiantnerd self-assigned this Jul 18, 2025
@defiantnerd
Copy link
Collaborator

Thanks, @SamWindell, well spotted. I will merge it when we solved the github builder issue

@baconpaul
Copy link
Collaborator

I've solved the GitHub issue; we just need to rebase next these prs.

git checkout next
git pull upstream next
git checkout my-branch
git rebase next my-branch
git push origin my-branch --force

is the common pattern if origin is set to your fork and upstream is set to free-audio/clap-wrapper

@defiantnerd defiantnerd added solved in next solved in branch "next" and removed solved in next solved in branch "next" labels Jul 18, 2025
@defiantnerd defiantnerd merged commit 48e3859 into free-audio:next Jul 18, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auv2 Everything related to AudioUnit V2 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants