Fix thread-safety when calling request_resize() #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joseph Lyncheski <directmusic94@gmail.com> Co-authored-by: Sam Windell <info@frozenplain.com>
Collaborator
Author
|
@SamWindell @directmusic |
SamWindell
reviewed
Jul 30, 2025
This was referenced Jul 30, 2025
baconpaul
pushed a commit
that referenced
this pull request
Jul 31, 2025
* request resize must be in the main thread on VST3 --------- Co-authored-by: Joseph Lyncheski <directmusic94@gmail.com> Co-authored-by: Sam Windell <info@frozenplain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch checks if calls to request_resize() happen on the main UI thread, and if not, sets a flag and stores the requested size so ClapAsVst3::onIdle() can handle the request.