Skip to content

Conversation

@thewheat
Copy link
Contributor

Fixes #1004

  • Did this by adding a new option in CleanHtmlFilter and setting it in the Cordova scraper
  • The indents are removed as they are a non breaking space character that gets removed by CleanHtmlFilter. The option allows bypassing the whitespace removal if it detects a non breaking space
  • I'm open to other ways of doing this more cleanly

Existing unindented with new indented
image

Source indented with new indented
image

@thewheat thewheat requested a review from a team as a code owner October 14, 2024 09:27
Do not use core/clean_html filter.
@simon04
Copy link
Contributor

simon04 commented Nov 17, 2024

In order to not pollute the core filters with rarely used options, I've created lib/docs/filters/cordova/clean_html_core.rb which is used instead of lib/docs/filters/core/clean_html.rb

Updating cordova docs is blocked since the scraper needs to be adapted to changes on cordova.apache.org. I'll merge nevertheless.

@simon04 simon04 merged commit 1da0de9 into freeCodeCamp:main Nov 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cordova: Indentation Problem

2 participants