Added a .gitignore and a longtap event listener#1
Open
qwazix wants to merge 39 commits intofreemangordon:nextfrom
Open
Added a .gitignore and a longtap event listener#1qwazix wants to merge 39 commits intofreemangordon:nextfrom
qwazix wants to merge 39 commits intofreemangordon:nextfrom
Conversation
Removed Clipboard functions from QmlMozContext
child() has bad refcounting and declarative trying to call deleteLater in some situations switch child() -> to child property in order to fix this problem
Maybe it make sense to keep it as only json message API which depends on components implementation
…ding, just assign it directly to QChar*
Move setPref API to child context
Scheduling QMozContext.runEmbeding to next event loop iteration in the constructor of QMozContext guaranties that gecko startup will happen in the next iteration. Thus the attribute autoInit in QMozContext::GetInstance() and explicit call to QMozContext::GetInstance()->runEmbedding(0) before starting Qt event loop are redundant.
…ance QmlMozContext is a declarative workaround for QMozContext singleton. Until there is a better support for singletons in QML make an instance of QMozContext to be global object in QML. Semantically a global instance makes clearer suggestion that it's a singleton than an attribute of a QML component.
Starting from Qt 4.4 QThread subclassing is considered to be a bad practice: a QThread should only manage a thread, not process data.
Make sematics of QMozContext clearer.
Conflicts: src/qgraphicsmozview.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a QML MouseArea over the QmlMozView it confuses tap-drags with longtaps, to avoid this without using hacks I added a noLongTapped() signal to the QmlMozView as suggested by romaxa and the result is more robust.