sbom serialNumber validation handled #195
Merged
+127
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omidtavakoli
requested review from
felixoldenburg,
loiro,
mohammedalics,
molikuner and
ocristian
molikuner
reviewed
Nov 14, 2025
...ker/src/main/java/com/freenow/sauron/plugins/generator/nodejs/NodeJsDependencyGenerator.java
Outdated
Show resolved
Hide resolved
ocristian
reviewed
Nov 14, 2025
Contributor
ocristian
left a comment
ocristian
left a comment
There was a problem hiding this comment.
I think we also discussed removing that field from the JSON, right? Wouldn’t it be less work to simply remove it? If I remember correctly, @omidtavakoli confirmed that DependencyTrack does not require it.
Contributor
Author
|
@ocristian We discussed at the same time to generate the field in the plugin if it was including the *** to not break DependencyTrack in future if it there was an update which uses that field |
Co-authored-by: omid.tavakoli <omid.tavakoli@free-now.com>
molikuner
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm sbom createa an invalid serialNumber like this "serialNumber": "urn:uuid:***" in NodeJsDependencyGenerator. This MR handles and introduces tests on the plugin