Quick Tag Selection With Floating List#12
Open
KyGuy2002 wants to merge 3 commits intofrigate-nvr:mainfrom
Open
Quick Tag Selection With Floating List#12KyGuy2002 wants to merge 3 commits intofrigate-nvr:mainfrom
KyGuy2002 wants to merge 3 commits intofrigate-nvr:mainfrom
Conversation
You can just press shift + s to go backwards, to be clear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very tedious currently to change labels on a bounding box because you can either:
a. Click edit, click dropdown, locate and click tag, click save.
b. Click s until you get to the label. Don't overshoot or you have to go all the way around again.
While the keyboard shortcuts are great it still feels very slow.
This PR aims to fix that by replacing the tag selection modal with a simplistic floating UI next to the bounding boxes showing all the list items. This changes the tag selection flow to just this:
a. Click a tag
b. Click s until you get to the label. You can see all the labels and the current one to prevent overshooting so you can time your last key perfectly.
The component has a max height and scrolls to prevent overflow:

The component switches to being aligned from the bottom when near the bottom of the image to avoid getting cut off:

The whole component is only visible when the box is selected so only one will ever be displayed and overlap isn't a concern
Let me know your thoughts on this addition. I feel it will make tag selection much quicker and less frustrating.
Thank you for your time and for this amazing free software!