Fletcher Bonds - homework complete#10
Open
fbonds wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Open
Fletcher Bonds - homework complete#10fbonds wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
fbonds wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Conversation
added 2 commits
April 12, 2020 15:35
t1mwillis
reviewed
Apr 24, 2020
| // Define class here | ||
| class DivElement extends HTMLElement { | ||
| constructor(content) { | ||
| super(content); |
There was a problem hiding this comment.
Suggested change
| super(content); | |
| super('div', content); |
Then you can remove the two lines below this.
t1mwillis
reviewed
Apr 24, 2020
| const lastName = names[1]; | ||
| const email = person.email; | ||
| const phone = person.phone; | ||
| people.forEach(([name, email, phone] = [people.name, people.email, people.phone]) => { |
There was a problem hiding this comment.
This is one way to do it!
I was thinking more like
people.forEach(({name, email, phone}) => {
const [firstName, lastName] = name.split[' ']
return `First name: ${firstName}
Last name: ${lastName}
Email: ${email}
Phone number: ${phone}`;
})
t1mwillis
reviewed
Apr 24, 2020
| const email = person.email; | ||
| const phone = person.phone; | ||
| people.forEach(([name, email, phone] = [people.name, people.email, people.phone]) => { | ||
| const { firstName, lastName } = name.split(' '); |
There was a problem hiding this comment.
This will not work, name.split returns an array.
const [firstName, lastName] = name.split(' ')
Author
There was a problem hiding this comment.
ah.. dang. I was judging success by 'npm test'. I don't think I actually tried to run any of them individually. 😳
t1mwillis
reviewed
Apr 24, 2020
| this.seconds -= 1; | ||
| }, 1000); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 1 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.