finished#12
Open
tanveeriali wants to merge 1 commit intofrontend-application-development-uw20:masterfrom
Open
Conversation
t1mwillis
reviewed
Apr 20, 2020
| class DivElement extends HTMLElement { | ||
| constructor(content) { | ||
| super('div', content); | ||
| this.content = content; |
There was a problem hiding this comment.
This works, but is not required. The super('div', content) sets the content.
t1mwillis
reviewed
Apr 20, 2020
| const lastName = names[1]; | ||
| const email = person.email; | ||
| const phone = person.phone; | ||
| people.forEach((person) => { |
There was a problem hiding this comment.
Suggested change
| people.forEach((person) => { | |
| people.forEach(({ email, phone, name }) => { |
You can destructure your arguments. Saves a few lines, but isn't always the most readable 🤷♀️
t1mwillis
reviewed
Apr 20, 2020
| this.seconds -= 1; | ||
| }, 1000); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 1 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.