Completed homework.#18
Open
dgallinger wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Open
Completed homework.#18dgallinger wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
dgallinger wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Conversation
Author
|
Completed homework. |
t1mwillis
reviewed
Apr 24, 2020
|
|
||
| class DivElement extends HTMLElements { | ||
| constructor(content) { | ||
| super(content); |
There was a problem hiding this comment.
Suggested change
| super(content); | |
| super('div', content); |
Then you don't need lines 8 or 9
t1mwillis
reviewed
Apr 24, 2020
| import people from './people.json'; | ||
|
|
||
| people.forEach(function (person) { | ||
| people.forEach((person) => { |
There was a problem hiding this comment.
Suggested change
| people.forEach((person) => { | |
| people.forEach(({ name, email, phone }) => { |
t1mwillis
reviewed
Apr 24, 2020
| } | ||
| } | ||
|
|
||
| Timer.prototype.start = function () { |
There was a problem hiding this comment.
This should be moved into the Timer constructor.
t1mwillis
reviewed
Apr 24, 2020
| Timer.prototype.start = function () { | ||
| var instance = this; | ||
| var timerInterval = setInterval(function () { | ||
| const instance = this; |
There was a problem hiding this comment.
Once in constructor, you can drop this line
t1mwillis
reviewed
Apr 24, 2020
| var timerInterval = setInterval(function () { | ||
| const instance = this; | ||
| const timerInterval = setInterval(() => { | ||
| if (instance.seconds === 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 1 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.