Sven Otto - week 2 submission#1
Open
Bl4ckH4wkGER wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Open
Sven Otto - week 2 submission#1Bl4ckH4wkGER wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Bl4ckH4wkGER wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Conversation
added 3 commits
April 18, 2020 09:18
t1mwillis
reviewed
May 6, 2020
| } | ||
|
|
||
| function AuthorBio(props) { | ||
| const isMediumMember = props.source.isMediumMember; |
There was a problem hiding this comment.
Suggested change
| const isMediumMember = props.source.isMediumMember; | |
| const { isMediumMember } = props.source; |
t1mwillis
reviewed
May 6, 2020
| className='missed-article author-image' | ||
| style={ isMediumMember ? {border: '5px solid green'} : {}} | ||
| src={props.source.image} | ||
| alt={props.source.image} |
There was a problem hiding this comment.
Typically the alt tag would be human readable, not a URL
t1mwillis
reviewed
May 6, 2020
| } | ||
|
|
||
| class MissedArticles extends React.Component { | ||
| static propTypes = { |
t1mwillis
reviewed
May 6, 2020
| ) | ||
| } | ||
|
|
||
| function DateAndDuration(props) { |
There was a problem hiding this comment.
I personally find these nested render functions within the same file somewhat hard to parse/understand. I guess it's personal preference, but I typically like to look in one place for the render function in a file to determine what the DOM output is going to look like.
t1mwillis
reviewed
May 6, 2020
| ) | ||
| } | ||
|
|
||
| function AuthorBio(props) { |
There was a problem hiding this comment.
Is this the same AuthBio as in missed-articles.js? Consider refactoring and importing to each.
|
Really great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
I felt like I was still missing the following crucial basic knowledge going into this exercise:
Over the course of the week I spent 20h on this assignment, a lot of which was reading documentation. I was hoping for more reference material and clarifying examples from the slides and inclass code.
I believe it is complete. PropTypes and CSS may we a little wonky