Skip to content

added assignment02#13

Open
zyang888 wants to merge 4 commits intofrontend-application-development-uw20:masterfrom
zyang888:master
Open

added assignment02#13
zyang888 wants to merge 4 commits intofrontend-application-development-uw20:masterfrom
zyang888:master

Conversation

@zyang888
Copy link

Week 2 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment: 3
  • Completion rating on this assignment: complete

div .container {
width: 80%;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work with the CSS, styling looks great!

return (
<section>
<div className="title"><h1>For you</h1></div>
{renderSquare(yourdata,"foryou")}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is very DRY! Nice.

import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import { faBookmark } from '@fortawesome/free-regular-svg-icons';

class Square extends React.Component {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider naming this something like Section

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, no propTypes? 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants