Week 2 Homework Lynne Cooney#3
Open
ilynne wants to merge 22 commits intofrontend-application-development-uw20:masterfrom
Open
Week 2 Homework Lynne Cooney#3ilynne wants to merge 22 commits intofrontend-application-development-uw20:masterfrom
ilynne wants to merge 22 commits intofrontend-application-development-uw20:masterfrom
Conversation
Merge completed assignment into master
bhague1281
reviewed
May 19, 2020
| "node-sass": "^4.13.1", | ||
| "react": "^16.13.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-scripts": "3.4.1" |
Contributor
There was a problem hiding this comment.
Note for next time, don't forget to include prop-types here as well.
bhague1281
reviewed
May 19, 2020
| "@testing-library/jest-dom": "^4.2.4", | ||
| "@testing-library/react": "^9.3.2", | ||
| "@testing-library/user-event": "^7.1.2", | ||
| "node-sass": "^4.13.1", |
bhague1281
reviewed
May 19, 2020
| } | ||
|
|
||
| ArticleList.propTypes = { | ||
| className: PropTypes.string.isRequired, |
Contributor
There was a problem hiding this comment.
Great job making this reusable in both sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
Note that I changed the default port to 4000. I use 3000 for a lot of work projects and it's just easier for me to use 4000 for class projects.